Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consensus: Utxoview based script validation #135

Merged
merged 7 commits into from
Jun 14, 2020
Merged

consensus: Utxoview based script validation #135

merged 7 commits into from
Jun 14, 2020

Conversation

adiabat
Copy link
Contributor

@adiabat adiabat commented May 28, 2020

It's a different way of doing #134 and doesn't do all the checks #134 has, but seems to work with minimal additions to btcd.

@kcalvinalvin
Copy link
Member

kcalvinalvin commented May 29, 2020 •
edited
Loading 

Creating new pollarddata                                                                                 │
panic: EOF                                                                                               │
                                                                                                         │
goroutine 8 [running]:                                                                                   │
github.com/mit-dci/utreexo/util.UblockNetworkReader(0xc00006c1e0, 0x65167f, 0xe, 0x3e800002103)          │
        /home/calvin/bitcoin-projects/utreexo/go/src/github.com/mit-dci/utreexo/util/utils.go:159 +0x2ac │
created by github.com/mit-dci/utreexo/csn.IBDClient                                                      │
        /home/calvin/bitcoin-projects/utreexo/go/src/github.com/mit-dci/utreexo/csn/client.go:52 +0x19d  │
Command exited with non-zero status 2                                                                    │
57.99user 9.07system 0:23.06elapsed 290%CPU (0avgtext+0avgdata 42616maxresident)k                        │
0inputs+0outputs (0major+11973minor)pagefaults 0swaps

I'm getting this from ibdsim side and pushBlocks GetUDataFromFile binary.Read offset 8450 EOF from the genproofs side. Not quite sure if this is the expected behavior.

Validation seems to be working.

kcalvinalvin
kcalvinalvin reviewed May 29, 2020
View reviewed changes
util/udata.go
@@ -2,6 +2,16 @@ package util

import (
"fmt"

"github.com/btcsuite/btcd/txscript"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra empty lines in imports shouldn't be there

@dergoegge
Copy link
Contributor

I'm getting this from ibdsim side and pushBlocks GetUDataFromFile binary.Read offset 8450 EOF from the genproofs side. Not quite sure if this is the expected behavior.

@kcalvinalvin This should be the same thing i ran into, that happens when genproofs is done sending blocks and closes the connnection. Got fixed with #136.

@kcalvinalvin kcalvinalvin mentioned this pull request Jun 5, 2020
Closed
adiabat added 5 commits June 5, 2020 16:24
@adiabat
make ToUtxoView method for UData
bfa8475 
There's currently no way to make UtxoEntries in btcd, and all the
fields are unexported so I added a NewUtxoEntry function there.
@adiabat
stat checking signatures
bc8233f
@adiabat
Use DedupeBlock skiplist to insert new utxos into the view on the fly
c758dee 
Seems to work!  Seems to be checking signatures which is cool.
@adiabat
actually check sigs with ValidateTransactionScripts()
9868dec
@adiabat
use wire.TxOut instead of separate amount, pkscript
a7a255d
@Rjected Rjected mentioned this pull request Jun 10, 2020
Merged
@adiabat
Copy link
Contributor Author

adiabat commented Jun 14, 2020 •
edited
Loading

I'm having some build weirdness on my local machine but I probably just don't have go mod set up right. Seems to work OK here though so merging. It still doesn't do everything, but it does the important signature checks.
Also -- big TODO -- it does 1 transaction at a time, so really need to change it to do all the transactions in parallel.

@adiabat adiabat merged commit 2c4fd88 into master Jun 14, 2020
kcalvinalvin added a commit to kcalvinalvin/utreexo that referenced this pull request Apr 10, 2024
@kcalvinalvin
Merge pull request mit-dci#135 from kcalvinalvin/2024-03-05-mappollar…
5da0067 
…d-translate-positions

mappollard: translate positions on GetLeafPosition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcalvinalvin kcalvinalvin kcalvinalvin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adiabat @kcalvinalvin @dergoegge